Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix(task): fix closure compatibility issue with ZoneDelegate._updateT… #878

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

qiyigg
Copy link
Contributor

@qiyigg qiyigg commented Aug 16, 2017

…askCount

onHasTask wasn't getting triggerred for the Angular Zone for setTimeout
when the application was closure compiled. This was causing errors with
Protractor not being able to wait for a closure compiled application using setTimeout.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@qiyigg
Copy link
Contributor Author

qiyigg commented Aug 16, 2017

Joined Google github org

@vikerman vikerman requested a review from mhevery August 16, 2017 20:04
…askCount

onHasTask wasn't getting triggerred for the Angular Zone for setTimeout
when the application was closure compiled. This was causing errors with
Protractor not being able to wait for a closure compiled application using setTimeout.
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@mhevery mhevery merged commit a03b84b into angular:master Aug 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants